Review Board

beta

a new class version

Pending Review
Updated 5 months, 4 weeks ago

powerman Reviewers
godsmack
None Review Board SVN
this is an attempt
yes, testing were done.
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:15 a.m.)

   

  
/trunk/reviewboard/admin/checks.py (Diff revision 1)
18
    if not _updates_required and not _install_fine and not True:
18
    if not _updates_required and not _install_fine:
are you sure about this?
  1. powerman 5 months, 4 weeks ago (May 26th, 2008, 8:17 a.m.)
    yeah, i'm sure... this is due to a new implementation...
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:21 a.m.)

   

  
  1. dan zop 5 months, 4 weeks ago (May 26th, 2008, 8:22 a.m.)
    ok... i'm right about this... ;-) 
    Good!
Ship it!
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:24 a.m.)
ok... the review it's ok...
go on...
  1. powerman 5 months, 4 weeks ago (May 26th, 2008, 8:27 a.m.)
    ok, thx!
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:45 a.m.)

   

  
/trunk/reviewboard/admin/checks.py (Diff revision 1)
18
    if not _updates_required and not _install_fine and not True:
18
    if not _updates_required and not _install_fine:
???
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:45 a.m.)

   

  
/trunk/reviewboard/admin/checks.py (Diff revision 1)
18
    if not _updates_required and not _install_fine and not True:
18
    if not _updates_required and not _install_fine:
prova...
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:46 a.m.)

   

  
Posted 5 months, 4 weeks ago (May 26th, 2008, 8:47 a.m.)

   

  
/trunk/reviewboard/admin/checks.py (Diff revision 1)
17
17
comment #2
/trunk/reviewboard/admin/checks.py (Diff revision 1)
18
    if not _updates_required and not _install_fine and not True:
18
    if not _updates_required and not _install_fine:
This is a change due to a new specification
Posted 1 month, 3 weeks ago (September 25th, 2008, 7:17 a.m.)

   

  
/trunk/reviewboard/admin/checks.py (Diff revision 1)
18
    if not _updates_required and not _install_fine and not True:
18
    if not _updates_required and not _install_fine:
this condition is removed, ok.